Support Clojure 1.12 Array class notation refinement
Description
Per
Problem
Currently, the function clojure.tools.reader.impl.commons/parse-symbol is fairly lax with what it allows, both in general and with regard to the forthcoming Clojure 1.12 Array class notation.
Clojure 1.11 (and all previous) disallow symbols like String/1, and Clojure 1.12-alpha12 (and presumably forthcoming versions) only allows the first of the above list.
Potential Solutions
Do nothing. It’s better to be permissive and make the user check for valid symbols.
Change the clojure reader to only allow array class notation symbols.
Approach
Update clojure.tools.reader.impl.commons/parse-symbol to check symbol names for numbers, and if they exist, validate it’s only 1-9. If so, put the qualifying symbol into the ns part of the symbol and the digit into the name part.
Patch
TRDR-73-4.patch
Screened by: Alex Miller
Environment
None
Attachments
4
Activity
Show:
Michael Fogus August 19, 2024 at 2:13 PM
Released in v1.5.0
Alex Miller July 1, 2024 at 2:19 PM
Looks good to me, will decide later when to merge.
Michael Fogus July 1, 2024 at 2:14 PM
Added additional tests.
Alex Miller June 28, 2024 at 6:25 PM
Maybe add tests for namespaced class java.lang.String and prim arrays?
Michael Fogus June 24, 2024 at 3:52 PM
I tweaked the -2 patch to put the array class pieces into the right symbol parts and fixed the read symbol test. I retained original attribution. Added -3 patch with these changes.
Per
Problem
Currently, the function
clojure.tools.reader.impl.commons/parse-symbolis fairly lax with what it allows, both in general and with regard to the forthcoming Clojure 1.12 Array class notation.Clojure 1.11 (and all previous) disallow symbols like
String/1, and Clojure 1.12-alpha12 (and presumably forthcoming versions) only allows the first of the above list.Potential Solutions
Do nothing. It’s better to be permissive and make the user check for valid symbols.
Change the clojure reader to only allow array class notation symbols.
Approach
Update
clojure.tools.reader.impl.commons/parse-symbolto check symbol names for numbers, and if they exist, validate it’s only 1-9. If so, put the qualifying symbol into the ns part of the symbol and the digit into the name part.Patch
TRDR-73-4.patch
Screened by: Alex Miller