xml reserved prefix causes failure in emit
Description
Environment
org.clojure/clojure "1.8.0"
openjdk version "1.8.0_144"
OpenJDK Runtime Environment (build 1.8.0_144-b01)
OpenJDK 64-Bit Server VM (build 25.144-b01, mixed mode)
Activity
Herwig Hochleitner November 13, 2017 at 11:50 PM
Fixed in 0.2.0-alpha5
Thanks for bearing with me!
import November 6, 2017 at 5:28 PM
Comment made by: malcolmjuxt
Hi Herwig,
Sorry for the delayed response.
I have been able to test this commit on quite a large project that uses data.xml extensively and all seems to be working well.
One minor point, I am seeing the following warning on the console, which you may consider fixing prior to release.
WARNING: merge already refers to: #'clojure.core/merge in namespace: clojure.data.xml.pu-map, being replaced by: #'clojure.data.xml.pu-map/merge
Best wishes,
Malcolm
Herwig Hochleitner October 24, 2017 at 6:51 PM
Hi, thanks for the report!
Sorry for the late reply, but the proper fix turned out to be quite large: https://github.com/clojure/data.xml/commit/60ba605b4f66e2ffb32e70bbadde0201f25e552d
The reason being, that, besides the bug in pu-map, there was lots of old workarounds, that could have already been deleted by introducing pu-map. Such are the perils of TDD.
I'd be grateful, if you could test it, before me doing a release.
Thanks!
import October 4, 2017 at 7:44 PM
Comment made by: malcolmjuxt
I should point out that removing the guard entirely fixes this issue for my use-case, and I suggest the fix only needs to ensure that the value of the uri is equal to 'http://www.w3.org/XML/1998/namespace'. So it feels like a simple fix, but I don't know the intent of the assoc! and whether this guard intends something else. I should have to defer to Herwig, who authored this code.
Affects version 0.2.0-alpha3
See https://www.w3.org/TR/2006/REC-xml-names11-20060816/
"The prefix xml is by definition bound to the namespace name http://www.w3.org/XML/1998/namespace. It may, but need not, be declared, and must not be undeclared or bound to any other namespace name. Other prefixes must not be bound to this namespace name, and it must not be declared as the default namespace."
The following XML string does not emit:
(emit-str (parse-str "<doc xml:lang=\"en\"/>"))
Instead it fails with the following error:
clojure.lang.ExceptionInfo
Mapping for xml: and xmlns: prefixes are fixed by the standard
{:attempted-mapping
{refix "xml", :uri "http://www.w3.org/XML/1998/namespace"}}
It fails because of the guard at the beginning of clojure/data/xml/pu_map.cljc line 38.
I think this guard should ensure that the correct ns of http://www.w3.org/XML/1998/namespace is given, but fails even if the correct ns is given.
I think this is Priority Major because the xml namespace is commonly used in many documents in real-world use, such as xml:id and xml:lang.