Some reflection warnings `[org.clojure/data.xml "0.2.0-alpha2"]`
Description
Environment
Attachments
- 17 Jun 2017, 08:54 AM
Activity
Herwig HochleitnerJune 22, 2017 at 1:06 AM
Michael du BreuilJune 21, 2017 at 1:55 AM
CA is now showing up on the clojure.org site, no badgering required.
Michael du BreuilJune 18, 2017 at 9:10 PM
I filled out the CA about 2 minutes before I sent the patch in here, so I suspect it's still in process somewhere. I'll give it a couple of days to give people a chance to allow that to go through before starting to ping people on it.
Herwig HochleitnerJune 18, 2017 at 6:08 PM
Thanks for your patch! Before moving this forward, we need to make sure that your contributor agreement is filed with Cognitect. Unfortunately, I can't find your name on https://clojure.org/community/contributors yet. If you have already sent the agreement, please ping Alex Miller to get your contributor status recognized.
Michael du BreuilJune 17, 2017 at 8:54 AM
reflection-1.patch addresses all the reflection in master (c803aebfa) in clojure/data/xml/jvm/emit.clj, as well as the getNamespaceURI call.
This is my first time submitting a patch to JIRA, so if I've made an error anywhere please let me know and I'm happy to try and address it.
Details
Assignee
Ryan SeniorRyan SeniorReporter
importimportPatch
CodePriority
Minor
Details
Details
Assignee
Ryan SeniorReporter
importPatch
Priority
Minor
When I include `[org.clojure/data.xml "0.2.0-alpha2"]`,
I encounter these reflection warnings on compilation:
```
Reflection warning, clojure/data/xml/jvm/parse.clj:54:24 - call to method getNamespaceURI on javax.xml.stream.XMLStreamReader can't be resolved (argument types: unknown).
Reflection warning, clojure/data/xml/jvm/parse.clj:128:5 - call to method createXMLStreamReader can't be resolved (target class is unknown).
Reflection warning, clojure/data/xml/jvm/emit.clj:97:33 - call to method isLoggable can't be resolved (target class is unknown).
Reflection warning, clojure/data/xml/jvm/emit.clj:98:28 - call to method log can't be resolved (target class is unknown).
Reflection warning, clojure/data/xml/jvm/emit.clj:123:27 - reference to field writeEndElement can't be resolved.
Reflection warning, clojure/data/xml/jvm/emit.clj:125:38 - call to method writeCharacters can't be resolved (target class is unknown).
Reflection warning, clojure/data/xml/jvm/emit.clj:129:38 - call to method writeComment can't be resolved (target class is unknown).
```
Hope that helps. Thanks for this library, it is pleasant to work with and has saved me many hours.