Extra out directory in path with load-file

Description

foo.cljs

Working with -d:

You will end up with out/out/cljs/user/fooAD3E4B4.js

Otherwise things appear to work.

Environment

{:deps {org.clojure/clojurescript {:mvn/version "1.10.238"}}}

Activity

Show:
Ruby
October 15, 2018, 7:38 PM

cljs.closure/compile-file adds :output-dir from opts to file, causing it to appear double. Passing (dissoc opts :output-dir) as third argument to cljs.closure/src-file->target-file (as is done in cljs.repl.rhino,nashorn,node,graaljs) avoids adding the first instance of output-dir to fix this bug, and fixes as well.

Mike Fikes
October 15, 2018, 11:14 PM

CLJS-2753.patch LGTM and passes in CI and Canary.

I confirmed correct behavior for the ticket as written and for and I also did some light testing with other scenarios.

Mike Fikes
May 12, 2019, 2:28 AM

CLJS-2753.patch added to Patch Tender

Mike Fikes
November 4, 2019, 4:02 AM

CLJS-2753.patch no longer applies

Assignee

David Nolen

Reporter

Mike Fikes

Labels

None

Approval

None

Patch

Code

Affects versions

Priority

Minor
Configure