Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Implicit casting behaviour of into-array differs from <primitive>-array

Description

The behavior of byte-array and short-array is inconsistent with the other <type>-array functions and with the into-array function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). byte-array and short-array throw a ClassCastException.

Example:

into-array (via RT.seqToTypedArray) and the other <type>-array functions all upcast to Number via Numbers.<type>_array), then obtain the proper primitive value. Numbers.byte-array and Numbers.short-array do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the into-array behavior. Tests are included. The submitter is a contributor.

Patch: clj766-2.patch

Screened by: Alex Miller

Environment

None

Attachments

2

Activity

Show:

Alex Miller August 29, 2013 at 9:10 PM

Updated patch to fix whitespace issues, add impl to include fixes in the other arity version of this function, added tests corresponding to the other arity version. Marking screened.

Karsten Schmidt July 24, 2013 at 10:36 PM

Just replied to Alex, sorry JIRA emails went into spam - wasn't aware of recent comments... will make time to work on remaining issues early next week. Thx.

Alex Miller May 4, 2013 at 2:32 AM

Sending back to Karsten for the requested patch updates.

Alex Miller May 4, 2013 at 2:31 AM

I think the patch approach is valid. However, the patch does not cover the same problem in the 2-arity version of byte_array and short_array (when a size is supplied). Please update the patch to include a fix in the 2-arity version of byte_array and short_array and tests for the same. Ex: (byte-array 1 [1]).

Also, there is a whitespace issue in the patch - please just use spaces!

Re Stuart's comments, I don't think that's in the scope of this ticket or solution.

Stuart Halloway March 30, 2013 at 2:53 PM

I agree that all the numeric array constructors should work the same way, but I am not sue we should adopt long-array's approach, which allows coercion from float to integer types.

Completed

Details

Assignee

Reporter

Approval

Ok

Patch

Code and Test

Priority

Affects versions

Fix versions

Created April 2, 2011 at 12:45 AM
Updated October 25, 2013 at 10:03 PM
Resolved October 25, 2013 at 10:03 PM