Set thread names on agent thread pools
Description
Environment
Activity
Andy FingerhutJuly 31, 2014 at 4:58 PM
Just a historical note for those doing code/ticket archaeology: This ticket appears to have resulted in the git version 351e05a242740cc415524d03e1d424de516eed75 which you can browse here on Github:
https://github.com/clojure/clojure/commit/351e05a242740cc415524d03e1d424de516eed75
importOctober 13, 2010 at 1:58 AM
Comment made by: importer
stu said: Updating tickets (#276, #280, #378, #437, #448)
importOctober 13, 2010 at 1:58 AM
Comment made by: importer
stu said: Second patch simply recreates first patch in the correct form. Please follow the instructions at http://clojure.org/patches when creating patches.
importOctober 13, 2010 at 1:58 AM
Comment made by: importer
stu said: [[file:cUhT1C1uCr35jCeJe5cbLA]]
importOctober 13, 2010 at 1:58 AM
Comment made by: importer
Converted from http://www.assembla.com/spaces/clojure/tickets/378
Attachments:
agent-name.diff - https://www.assembla.com/spaces/clojure/documents/bLEf-eC8Sr373-eJe5cbLA/download/bLEf-eC8Sr373-eJe5cbLA
0378-as-git-patch.patch - https://www.assembla.com/spaces/clojure/documents/cUhT1C1uCr35jCeJe5cbLA/download/cUhT1C1uCr35jCeJe5cbLA
It���s a best practice to name the threads in an executor thread pool with a custom ThreadFactory so that the purpose of these threads is clear in thread dumps and other runtime operational tools. By default these threads are currently called something like "pool-%d-thread-%d", and this is what you���ll see for the agent send thread pools.
I created a patch to do this with thread names like:
clojure-agent-send-pool-%d ��� should be fixed # of threads
clojure-agent-send-off-pool-%d ��� will be added and removed over time
The patch is attached and I have a signed CA.