Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Eliminate unneeded call in new fast drop support

Description

In the 1.12.0-alpha1 changes for https://clojure.atlassian.net/browse/CLJ-2713 there is some dead code that should be removed, an extra call to vec.arrayFor(i)in PersistentVector:

if(i < vec.cnt) { // in vec Object[] array = vec.arrayFor(i); ;; <-- UNUSED int newOffset = i%32; return new ChunkedSeq(vec, vec.arrayFor(i), i-newOffset, newOffset); } else { ...

Proposed: remove dead code

Patch: clj-2740.patch

Screened by: fogus

Environment

None

Attachments

1
  • 05 Dec 2022, 10:41 PM

Activity

Show:

Alex MillerMarch 8, 2023 at 3:53 PM

Applied for release in 1.12.0-alpha2

Fixed

Details

Assignee

Reporter

Approval

Ok

Patch

Code

Priority

Affects versions

Fix versions

Created December 5, 2022 at 10:39 PM
Updated March 8, 2023 at 3:53 PM
Resolved March 8, 2023 at 3:53 PM