Elevate phase in throwable data and conveyance for prepl

Description

Problems:

  • phase is currently buried in ex-data of top wrapper exception

  • prepl is conveying exception phase in message instead of in exception data

  • error phases are not currently documented

  • LispReader$ReaderException is not an exception info

Changes:

  • clojure.core.server:

    • prepl sets error phase in throwable data

    • messages for thrown exception are marked with `:exception` flag

  • clojure.core-print:

    • Improve docstring for StackTraceElement->vec

    • Improve docstring for Throwable->map

    • Elevate phase to top-level hase key in Throwable->map

  • clojure.main

    • Fix reflection warning in core-class?

    • Add phase list in ex-triage docstring

    • Updated ex-triage to handle changes in :read-source and :read-eval-result phases

    • Simplified code for exceptions thrown in clojure.main/repl

  • LispReader

    • Make ReaderException an IExceptionInfo

Patch: clj-2430-2.patch

Environment

None

Attachments

2

Activity

Show:

Alex MillerNovember 16, 2018 at 3:25 PM

-2 fixes a bug that lose the phase in ex-triage

Completed

Details

Assignee

Reporter

Approval

Ok

Patch

Code

Priority

Affects versions

Fix versions

Created November 15, 2018 at 8:48 PM
Updated November 16, 2018 at 7:28 PM
Resolved November 16, 2018 at 7:28 PM