case with byte value causes CompilerException

Description

Summary: The Clojure ASM upgrade exposed a regression in ASM. This patch matches the patch being applied to ASM.

Approach: Copy the patch being made to ASM https://gitlab.ow2.org/asm/asm/commit/7d045e01cdadad95d62534ef92cb0eca2eec1a17 plus add test

Patch: 0001-CLJ-2367-Incorporate-ASM-merge-request-189-and-add-c.patch

Repro
Clojure 1.10.0-alpha5 fails as follows:

Screening Notes: I followed all the discussion/links and concur with the assessment, and that this patch matches the fix being applied to ASM.

Environment

None

Activity

Show:
Daniel Sutton
June 30, 2018, 5:28 PM

from the ow2 ticket:

> Thanks for your report. The regression was actually introduced by a4b16ab3, and will be fixed with !189.

https://gitlab.ow2.org/asm/asm/merge_requests/189

Alex Miller
June 30, 2018, 8:39 PM

Would be great if someone could make a patch in the Clojure equivalent version of this code and test...

Sean Corfield
July 1, 2018, 2:33 AM

Sure, I'll update my patch to include the changes from merge_requests/189, revert the Compiler.java change, and still include the new tests.

Sean Corfield
July 1, 2018, 2:36 AM

Updated patch: preserves new case tests, reverts Compiler.java change, incorporates GeneratorAdapter.java changes from their merge request 189.

Daniel Sutton
July 3, 2018, 7:27 PM
Completed

Assignee

Unassigned

Reporter

Sean Corfield

Labels

Approval

Ok

Patch

None

Fix versions

Affects versions

Priority

Critical
Configure