Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Make some Clojure tests independent of hash function used

Description

The most interesting failures with the new hash function are probably the 3 deftest's in multimethods.clj that define the same multimethod name 'simple', and thus whether they pass or fail depends upon the order that they are executed. They are currently executed in an order that allows them to pass. Found this while testing murmurHash3 changes to Clojure, which caused the deftest's to execute in a different order and fail.

Simplest way to eliminate this dependency on order is to make the multimethod names unique in each test, so none of them depends upon state left behind by the others.

Environment

None

Attachments

2
  • 31 Jan 2014, 09:43 PM
  • 30 Jan 2014, 04:52 AM

Activity

Show:

Andy Fingerhut January 31, 2014 at 9:43 PM

clj-1328-v4.diff is identical to clj-1328-v3.diff, except it adds a comment explaining why the case hash collision tests don't need to change much, and it puts in a couple of missing (is ...) around some equality tests.

Andy Fingerhut January 30, 2014 at 4:52 AM

Updates one more test than the previous patch.

Andy Fingerhut January 30, 2014 at 2:11 AM

Updates some, but not all, tests that were recently modified or disabled due to change in hash function.

Andy Fingerhut January 20, 2014 at 7:18 PM

Patch clj-1328-v1.diff makes all defmulti names unique in multimethods.clj, so that no deftest result depends upon state left behind by another.

Completed

Details

Assignee

Reporter

Approval

Ok

Patch

Code and Test

Priority

Affects versions

Fix versions

Created January 20, 2014 at 7:16 PM
Updated February 7, 2014 at 8:34 PM
Resolved February 7, 2014 at 8:34 PM