All work
- prepl responses do not indicate if they're an exception or notCLJS-3096Resolved issue: CLJS-3096David Nolen
- cljs.repl is not loaded in node socket io-prepl, which is required for formatting errors (err->str)CLJS-3022
- Errors that occour in a ClojureScript pREPL connection are :ret as data under :val, not as a stringCLJS-2994Resolved issue: CLJS-2994Mike Fikes
- When using remote prepl server, *repl* is false, preventing use of add-lib etcCLJ-2897
- clojure.core.server/io-prepl returns immediately with read-lineCLJ-2692
- prepl warnings remain buffered until explicit flushing from the clientCLJ-2645Resolved issue: CLJ-2645
- io-prepl and remote-prepl have asymmetric handling of :exception :val'sCLJ-2620Resolved issue: CLJ-2620
- prepl does not run with a DynamicClassLoaderCLJ-2540
- remote-prepl blocks main-thread upon in-reader's eosCLJ-2509
- prepl docstring doesn't correctly doc exception :ret mapsCLJ-2495Resolved issue: CLJ-2495
- Allow reader conditionals in preplCLJ-2453Resolved issue: CLJ-2453
11 of 11
Description
None
Environment
None
Attachments
1
Details
Assignee
David NolenReporter
Oliver CaldwellApproval
ScreenedPatch
CodePriority
Blocker
Details
Details
Assignee
Reporter
Approval
Screened
Patch
Code
Priority
Activity
Show:
David NolenJuly 15, 2021 at 4:49 PM
Shogo OhtaJune 24, 2021 at 12:54 PMEdited
What is the blocker here? The patch looks fine. I recently found it hard for a prepl client to properly handle errors without this change.
Mike FikesJune 13, 2019 at 10:05 PM
CLJS-3096.patch added to Patch Tender
Mike FikesJune 10, 2019 at 10:58 PM
CLJS-3096.patch passes CI
Oliver CaldwellJune 5, 2019 at 8:50 AM
If this is considered valid I'll submit a patch for it today. As far as I can tell from all of my work with prepls over the last few months this is one of the last major outstanding features. Once https://clojure.atlassian.net/browse/CLJ-2453#icft=CLJ-2453 is in we'll have reader conditionals in both Clojure and ClojureScript too.
The only thing I haven't been able to do is set the current line / column / file path for ClojureScript evals, but that's off topic.
fixed https://github.com/clojure/clojurescript/commit/3e9d650ede64e707040249cbebb07f03392ab75d