Uploaded image for project: 'tools.trace'
  1. TTRACE-6

Remove unnecessary (?) (def ~name) from deftrace

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Completed
    • Labels:
      None

      Description

      I was working on enhancements to a lint tool and trying it out on contrib libraries to see if any of them have redefinitions of symbols. It found that every use of deftrace causes a redefinition. Looking at deftrace's definition, I cannot see any reason for the (def ~name) before the later (defn ~name ...) expression. The later expression is done unconditionally, unlike the way deftest or defmulti always def a var, then redefine it if it was unbound.

      I could easily be missing something important here, but is there a reason for the (def ~name)?

        Attachments

          Activity

            People

            • Assignee:
              lprefontaine Luc Préfontaine
              Reporter:
              jafingerhut Andy Fingerhut
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: