Uploaded image for project: 'tools.reader'
  1. TRDR-32

Reading comment should not throw exception

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Declined
    • Labels:
      None

      Description

      I have notice a discrepancy in how comments are read between cljs.tools.reader/read-string and cljs.reader/read-string.

      In cljs.reader, as shown here no exception is thrown but nil is returned, concretely ignoring the comment.

      Conversely, the following throws:

      (r/read-string {:read-cond :allow :features #{:cljs ;; comment) ;;+> EOF

      In my opinion the cljs.reader is the correct one and cljs.tools.reader should be patched, but of course there might be a reason I ignore to throw an exception.

        Attachments

          Activity

            People

            • Assignee:
              bronsa Nicola Mometto
              Reporter:
              arichiardi Andrea Richiardi
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: