Wasted call to str in read-ns-decl

Description

The function read-ns-decl (both copies in each of two namespaces) contain the expression:

This is equivalent to (read rdr), plus a wasted call to str whose return value is discarded.

Environment

None

Activity

Show:
Stuart Sierra
December 2, 2013, 6:07 PM

The call to str was added to force the Clojure reader to throw exceptions immediately when it encounters a syntax error. See TNS-1

Andy Fingerhut
December 2, 2013, 10:20 PM

Sorry for the noise. I was trying out pre-release version of Eastwood linter on as many contrib libraries as possible, and it found that odd-looking code. It didn't occur to me to look through the commit history to see when it became like it was, and why. Subtle.

Stuart Sierra
January 10, 2014, 5:26 PM

Mark old resolved issues as 'closed'

Declined

Assignee

Stuart Sierra

Reporter

Andy Fingerhut

Labels

None

Approval

None

Patch

None

Priority

Trivial