Dependency resolution depends on order in map

Description

tools.deps seems to return different results based on the order the dependencies are placed inside the dependency map.

That is,

and

may return different results. I would expect the order in the dependency map to not matter.

I have attached a patch with a minimal reproducible test case for this issue, which currently fails.

Activity

Show:
Alex Miller
February 5, 2021, 3:37 PM

There have been a lot of changes in the expansion code since this was filed and to a large degree this kind of thing has been fixed. I wouldn't guarantee that dep definition ordering could not affect outcome as it is still a single pass algorithm where order of encounter can affect the data structure, but I think the particular issue causing this test to fail has been addressed.

I added the test to the code base to keep it around.

Fixed

Assignee

Alex Miller

Reporter

hyPiRion