The CLJS dep can't be easily upgraded

Description

The CLJS compiler seems to have changed the options it expects, so what's in the project.clj is offending it.

Upgrading is useful so that the tests can properly test edn/keyword roundtrips, which currently cannot be done because old cljs versions can't (cljs.reader/read-string ":/").

Have to figure out how to make the node-dev and node-adv tests work, primarily.

Remember to:

  • Update the test instructions in the README if appropriate

  • Remove the reader conditionals related to :/ in test.cljc.

Environment

None

Activity

Show:
Nate Smith
November 18, 2017, 6:32 PM

I've attached patch with an update to ClojureScript and lein-cljsbuild. The reader conditionals have been removed and tests pass in both node-dev and node-adv.

gfredericks
November 18, 2017, 7:39 PM

Applied on master, thanks

Completed

Assignee

Nate Smith

Reporter

gfredericks

Labels

None

Approval

None

Patch

None

Priority

Minor