Refactor clojure-test-test assertions out of test-ns-hook

Description

The test assertions in clojure-test-test are run entirely within the test-ns-hook. This makes the code difficult to read and maintain as the assertions are not differentiated by logical scope other than by position.

Likely the code was written this way to avoid running the tests defined by defspec during the test run. This can be avoided by filtering the tests within test-ns-hook, allowing assertions to be grouped by deftest in the main body of the namespace.

Environment

None

Activity

Show:
Michael Glaesemann
July 6, 2017, 11:25 PM

I've just signed the Clojure CA.

This refactoring entailed a number of individual steps. I can provide individual patches if you'd like. Just let me know.

gfredericks
July 8, 2017, 3:19 AM

This is really good, thanks. I'm planning on applying it as soon as I get confirmation of the CA.

gfredericks
July 11, 2017, 1:35 PM

I just applied the patch to master.

Michael Glaesemann
July 11, 2017, 4:27 PM

Thanks!

Completed

Assignee

gfredericks

Reporter

Michael Glaesemann

Labels

None

Approval

None

Patch

Code and Test

Priority

Major