We're updating the issue view to help you get more done. 

Fast way to print indented json

Description

Hi!

Formatted json is very handy for human consumption, for example, while debugging or exploring JSON API. data.json offers formatting in a form of pprint-json. Problem is, pprint-json is dead slow because it tries to fit everything within some line width limit. In practice it takes 20-100 times more time to use pprint-json instead of write-str, up to the point where it just cannot be used in production:

1 2 3 4 5 6 7 8 clojure.data.json=> (def data (read-string (slurp "sample.edn"))) #'clojure.data.json/data clojure.data.json=> (count data) 4613 clojure.data.json=> (time (do (clojure.data.json/write-str data) nil)) "Elapsed time: 219.33 msecs" clojure.data.json=> (time (do (with-out-str (clojure.data.json/pprint-json data)) nil)) "Elapsed time: 25271.549 msecs"

Proposed enhancement is very simple: indent new keys and array elements, but do not try to fit values into line width limit. For human, JSON formatted this way is still easy consumable, structure is evident. The only downside is that some lines might become very long.

In a patch attached, I modified write-array and write-object, added new :indent option to write. To print indented json, one can write now: (write-str data :indent true)

There's some performance penalty, of course, but relatively small:

1 2 clojure.data.json=> (time (do (clojure.data.json/write-str data :indent true) nil)) "Elapsed time: 250.18 msecs"

I also fixed small bug: (seq m) thing in write-object should be (seq x).

Environment

None

Status

Assignee

Unassigned

Reporter

Nikita Prokopov

Labels

None

Approval

None

Patch

None

Priority

Major