Switch to tools.reader for cljs.analyzer/forms-seq

Description

Switches cljs.analyzer to use tools.reader, so we can get more accurate column location for symbols, prepping for more fleshed-out source maps.

Environment

CLJS master

Activity

Show:
David Nolen
July 15, 2013, 4:43 PM

Excellent, we need two more things in this patch, can you update bootstrap.sh and the POM file? Thanks.

Sean Grove
July 15, 2013, 5:00 PM

Updated with POM information and bootstrap update

Sean Grove
July 22, 2013, 8:20 PM

CA's been processed and I'm listed on the contributing page, so shouldn't be blocked by that any longer.

David Nolen
July 27, 2013, 8:09 PM

I tried applying this patch and rerunning the bootstrap script. This works but when I try to run script/test I get an error about the tools.reader not being on the classpath. Even trying to require tools.reader at via the repl doesn't work for me.

David Nolen
July 29, 2013, 5:14 PM
Completed

Assignee

Unassigned

Reporter

Sean Grove

Approval

None

Patch

Code

Priority

Major