--install-deps no longer install :npm-deps from deps.cljs from dependencies

Description

On 1.10.773 this would create a package.json and node_modules directory, pulling in the npm-deps specified by cljs.java-time.

clojure -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.773"} cljs.java-time/cljs.java-time {:mvn/version "0.1.16"}}}' -m cljs.main --install-deps

On current master neither are created, npm is never invoked. This seems to have started with commit 42bcb07b8bf23d57f98e4617e4c4c93347f09715 (https://github.com/clojure/clojurescript/commit/42bcb07b8bf23d57f98e4617e4c4c93347f09715)

To reproduce:

clojure -Sdeps '{:deps {org.clojure/clojurescript {:git/url "https://github.com/clojure/clojurescript" :sha "42bcb07b8bf23d57f98e4617e4c4c93347f09715"} cljs.java-time/cljs.java-time {:mvn/version "0.1.16"}}}' -m cljs.main --install-deps

Environment

None

Activity

Show:
Arne Brasseur
August 6, 2020, 3:59 PM

Added a patch that adds a simple nil-check

Conversation related to this issue

David Nolen
August 7, 2020, 1:07 PM

Assignee

Unassigned

Reporter

Arne Brasseur

Labels

None

Approval

Accepted

Patch

None

Priority

Major
Configure