tap> returning non-Boolean value in CI

Activity

Show:
Mike Fikes
August 6, 2020, 7:29 PM

Adding this bit of code to the unit test

shows that setTimeout is returning either null or undefined:

Of course, revising *exec-tap-fn* to coerce the return value would ensure we get a Boolean result, but this feels like it might be a workaround for a defect in this build of JSC:

Mike Fikes
August 6, 2020, 8:42 PM

Further investigation shows that JSC is actually returning undefined:

prints

David Nolen
August 7, 2020, 12:17 AM

exists? uses (some? ...) which is just (not (nil? ...)) which due to nil? treats undefined and null as the same thing via coercive-=. I think a better check for your last comment is (nil? ...) instead of (identical? nil ...)

David Nolen
August 7, 2020, 12:49 PM

Sorry I misunderstood, I think the boolean coercion is fine for now.

David Nolen
August 7, 2020, 12:50 PM

Assignee

David Nolen

Reporter

Mike Fikes

Labels

None

Approval

None

Patch

None

Priority

Major
Configure