Over aggressive call elimination invoking sets

Description

A regression was introduced with https://github.com/clojure/clojurescript/commit/1a537e57a1fda9ac54f86ed4a88e92713aefdb36 where the optimization is overly aggressive in the case of invoking sets on values returned by Node calls.

Repro:

Note that in the above, this can be worked around by suppressing the optimization with an ^any hint.

Using the parent commit SHA shows that things were fine prior to this commit of interest:

This issue was discovered via Canary for the Hoplon project which has a similar expression [1]

[1] https://github.com/hoplon/hoplon/blob/d502e3dd0370b1d86dafca6153a3aa94a3056fb5/src/hoplon/jquery.cljs#L119

Environment

None

Activity

Show:
Mike Fikes
August 11, 2019, 11:01 PM

No longer broken with latest commits on master.

Assignee

Unassigned

Reporter

Mike Fikes

Labels

None

Approval

None

Patch

None

Priority

Major
Configure