CI script can indicate pass on failure

Description

Actual Behavior & Analysis

While working on other bash scripts, I noticed a small bug in .travis.yml. It checks for success with:

But this will match any failure count that ends in 0, to illustrate problem:

Fix

Match to start of line with ^, to illustrate fix:

Testing notes

  1. fork clojurescript

  2. setup to build fork on Travis CI

  3. create CLJS-3114 branch

  4. push branch with no changes

  5. witness successful build - https://travis-ci.org/lread/clojurescript/builds/550999841#L3140

  6. push CLJS-3114 with fix as described above

  7. witness sucessful build - https://travis-ci.org/lread/clojurescript/builds/551009119#L3140

Environment

None

Activity

Show:
Lee Read
June 26, 2019, 10:07 PM

Ready for review. Seems pretty straightforward but let me know, thanks!

Mike Fikes
August 20, 2019, 1:00 AM
Edited
Mike Fikes
August 20, 2019, 11:40 AM
Mike Fikes
August 20, 2019, 11:48 AM
Mike Fikes
March 29, 2020, 7:38 PM

CLJS-3114.patch has conflicts with master

Assignee

Lee Read

Reporter

Lee Read

Labels

None

Approval

None

Patch

None

Priority

Minor
Configure