Check for pair when conj vector on map

Description

For parity with Clojure, add runtime checks in map conj implementations such that vector arguments must be pairs.

Clojure:

ClojureScript:

Rationale: Even though this would reject some programs, those programs are incorrect and non-portable to Clojure.

Environment

None

Activity

Show:
Mike Fikes
November 17, 2019, 11:02 PM
Edited

CLJS-3111-4.patch

Travis

Details

AppVeyor

Details

Canary

Details

Patch Tender

Details

Roman Liutikov
November 17, 2019, 8:40 PM

Patch CLJS-3111-4 added

Mike Fikes
November 4, 2019, 4:04 AM

CLJS-3111-3.patch no longer applies

Mike Fikes
July 22, 2019, 3:17 AM

CLJS-3111-3.patch passes CI
CLJS-3111-3.patch added to Patch Tender

Roman Liutikov
July 21, 2019, 7:37 PM

Added updated patch with the above three optimizations. Benchmarks indeed looking better now.

Assignee

Mike Fikes

Reporter

Mike Fikes

Labels

Approval

None

Patch

Code and Test

Priority

Major