dir fails if string require used

Description

Instead, expect that dir would show the vars in the clojure.set namespace.

Environment

None

Activity

Show:
David Nolen
August 20, 2019, 2:26 AM

Hrm but will this patch work for invalid symbols due to Node.js requires? i.e "@foo/bar”?

Mike Fikes
August 19, 2019, 11:29 PM

If you look through the codebase, you will find uneven support for string-based namespaces in the form of conversions from strings to symbols at certain places.

A more principled approach, but yet more invasive, might involve reassessing the entire situation and perhaps ensuring that only symbols end up in the compiler state for all cases where the namespace can be represented as symbols.

This patch instead works by simply adding another such conversion where it matters for the specific issue describe in this ticket.

Mike Fikes
May 26, 2019, 1:03 PM

CLJS-3090.patch added to Patch Tender

Mike Fikes
May 21, 2019, 10:51 AM

CLJS-3090.patch passes CI

Assignee

Mike Fikes

Reporter

Mike Fikes

Labels

None

Approval

None

Patch

Code

Priority

Minor