Make :graaljs and :nashorn main files work without java package globals

Description

output-main-file for nashorn and graaljs targets make use of java.io.File. This makes the produced artifact not work when trying to execute it with js.java-package-globals (see CLJS-3087)

It should either just concat the path strings with a forward slash, which should also work just fine on Windows as per https://docs.oracle.com/javase/8/docs/technotes/guides/scripting/nashorn/shell.html (unfortunately I don't have a machine to verify) or use the Java.type approach used in graaljs_load

Environment

None

Activity

Show:
Mike Fikes
May 22, 2019, 2:07 AM

CLJS-3089.patch passes CI

Mike Fikes
May 26, 2019, 1:04 PM

CLJS-3089.patch added to Patch Tender

Dieter Komendera
August 7, 2019, 9:58 AM

Tested CLJS-3089.patch on Linux with OpenJDK 8 and on Windows using the Windows Subsystem Linux.

Mike Fikes
March 29, 2020, 7:54 PM

CLJS-3089.patch conflicts with master. Is this patch still relevant given the removal of Nashorn and GraalJS shipping REPL envs?

Dieter Komendera
March 29, 2020, 7:56 PM

Yes, this can be closed.

Won't Fix

Assignee

Dieter Komendera

Reporter

Dieter Komendera

Labels

None

Approval

None

Patch

None

Priority

Minor