Namespace starting with `com` broken in graaljs replenv

Description

With graal installed:

Environment

None

Activity

Show:
David Nolen
June 14, 2019, 8:52 PM

I'm leaning towards the second patch which disables implicit global imports. It's an ugly thing to rely on anyway ... for another ticket - but wondering if we should have `require` support for Java packages.

Dieter Komendera
June 14, 2019, 9:01 PM
Edited

GraalVM ships with a bin/js and bin/nodejs binary, both use the GraalJS engine, but they default js.java-package-globals to true. So if one would use GraalVM's nodejs to run a ClojureScript artifact, they would still encounter issues regarding namespaces with one of the problematic prefixes. This of course is out of ClojureScript's control, but I thought it puts another perspective on the patch, as it doesn't cover all possible paths on how one can run into this issue.

Dieter Komendera
June 14, 2019, 9:11 PM
Edited

Work has started to remove all usage of java-package-globals here:

Mike Fikes
March 29, 2020, 7:43 PM

CLJS-3087-2.patch conflicts with master, but perhaps we can close this ticket given the removal of the GraalJS REPL env

Dieter Komendera
April 4, 2020, 1:31 PM

Yes, this can be closed.

Won't Fix

Assignee

David Nolen

Reporter

Dieter Komendera

Labels

None

Approval

None

Patch

None

Priority

Minor