Eliminate empty line after enhanced execution phase error printing

Description

There is not normally an empty line after an enhanced error printout. See Clojure, and for example, see this example in ClojureScript:

But, with and you can see that there is an extra blank line for :clojure.error.phase :execution printing.

The attached patch eliminates this extra blank line, making things consistent within ClojureScript and also consistent with Clojure. Here is an example with the patch:

and without the patch you would see:

A slight difficulty is that the enhanced error printing strings have newlines at the end. See for example:

https://github.com/clojure/clojurescript/blob/6ccb629e365f46a9516e4defeced652cce9d4d35/src/main/cljs/cljs/repl.cljs#L188

The display error code is used for other errors, so the fix taken in this patch is to enforce uniformity by employing trimr.

Environment

None

Activity

Show:
Mike Fikes
December 15, 2018, 3:28 AM

CLJS-3012.patch passes CI

Assignee

David Nolen

Reporter

Mike Fikes

Labels

None

Approval

None

Patch

Code

Priority

Minor