Avoid Nashorn deprecation warning

Description

With JDK 11:

While this is perhaps a useful warning, the fact that it appears twice and the fact that it could conceivably break scripts that are using Nashorn, makes me think we should suppress this warning.

This can be suppressed per https://bugs.openjdk.java.net/browse/JDK-8210140 by ensuring that "--no-deprecation-warning" is in the args vector https://github.com/clojure/clojurescript/blob/6eedd0a08c49f7b0d4dcb30977b2fb38c90577bd/src/main/clojure/cljs/repl/nashorn.clj#L32

If this is added, we should test that adding this argument doesn't break things on, say JDK 8.

Environment

None

Activity

Show:
Mike Fikes
October 11, 2018, 4:59 PM

For Eugene's CA status see CLJS-2729.

Mike Fikes
October 11, 2018, 9:33 PM

CLJS-2927.patch LGTM and passes in CI.

Another place where this patch is needed is if you start a server REPL. For example, you will see this if you start one and then connect to port 5555.

With the patch, this output is eliminated.

Mike Fikes
October 14, 2018, 2:40 PM

Eugene, one minor improvement that could be made to the patch is to simply use a vector instead of a set for the list of JDK versions.

Eugene Kostenko
October 15, 2018, 9:09 AM

Thanks, Mike. The patch is updated.

Mike Fikes
February 10, 2019, 8:40 PM

CLJS-2927-2.patch passes CI

Assignee

David Nolen

Reporter

Mike Fikes

Labels

Approval

None

Patch

Code

Priority

Major
Configure