Make utility fn vars in cljs.spec.test.alpha private

Description

These utility fns in cljs.spec.test.alpha weren't intended for public use: distinct-by, get-host-port, get-ua-product, get-env

Environment

None

Activity

Show:
Mike Fikes
September 22, 2018, 11:56 PM

Hey Julio, have you signed the CA? (I don't see your name listed here https://clojure.org/community/contributors)

If not, see https://clojurescript.org/community/contributing

Julio Berina
September 23, 2018, 12:06 AM

Yes. I have signed the CA since September 5. From what I saw online, it takes like a couple of months to update the contributor list

Mike Fikes
September 23, 2018, 12:17 AM

Thanks, Julio. Your patch is probably fine. One aspect to consider is that defn- is typically used instead of private meta.

Julio Berina
September 23, 2018, 12:21 AM

I initially thought of doing that because I thought it was the other way around (private meta over defn-). Thank you for letting me know. I'll remember that for next time.

Mike Fikes
September 23, 2018, 1:17 AM

CLJS-2849.patch LGTM and passes tests.

Assignee

David Nolen

Reporter

Mike Fikes

Labels

Approval

None

Patch

None

Priority

Minor
Configure