Make cljs.repl/special-doc-map accessible to self-host

Description

It would be a good thing to move cljs.repl/special-doc-map and cljs.repl/repl-special-doc-map to a place that is also accessible to self-host environments.

At the moment both Planck and Lumo just copy them in their code base. This is error prone and requires manual maintenance, together with being a bit hard to handle in downstream tooling - the tool now needs to know the three places where the maps are placed.

I can provide a patch so I am going to ask a) if my proposal makes sense b) what is the best way to shared them between the clj and cljs world.

Environment

None

Activity

Show:
Andrea Richiardi
August 10, 2018, 4:45 AM

Any comment, feedback, deniable denial on this one ? I really think these should be somewhat public so that tooling avoids replicating them.

David Nolen
August 10, 2018, 8:26 PM

Go for it!

Andrea Richiardi
November 26, 2018, 12:46 AM

Attached a patch moving the two maps to cljs.env. I hope it makes sense in terms of naming.

Andrea Richiardi
November 30, 2018, 3:25 PM

I kind of think that this is not a big deal though. So feel free to dismiss this.

Assignee

Andrea Richiardi

Reporter

Andrea Richiardi

Labels

Approval

None

Patch

None

Priority

Minor
Configure