cljs.main: With temp dir, src attribute /main.js in default index.html

Description

With the new feature to use a temp output dir, the script tag has an odd src attribute

Repro:

If, on the other hand you do

you get

Environment

{:deps {org.clojure/clojurescript {:git/url "https://github.com/clojure/clojurescript" :sha "7aca40c4b6131b8e08153809a410c06bdfa567ab"}}}

Activity

Show:
Mike Fikes
March 7, 2018, 1:32 AM

The attached patch simply defaults to "out" if output-dir is not set, but only for the purposes of the rendering call default-index.

Mike Fikes
March 7, 2018, 4:08 AM

This is actually incorrect to do. If the user copies the index.html that this patch renders, then the REPL no longer works because it no longer points to the main.js.

Mike Fikes
March 7, 2018, 12:49 PM

The (more complicated) patch 2 adds logic that doesn't use a temp out dir if index.html exists.

Mike Fikes
March 11, 2018, 2:14 PM

Third patch rebaselines.

Mike Fikes
May 8, 2018, 4:29 PM

CLJS-2624-4.patch rebaselines

Assignee

Mike Fikes

Reporter

Mike Fikes

Labels

None

Approval

None

Patch

Code

Priority

Major
Configure