Uploaded image for project: 'ClojureScript'
  1. CLJS-2238

Perf regression with node module indexing

    Details

    • Approval:
      Accepted
    • Patch:
      Code

      Description

      On master, I'm observing that, using Figwheel, changes to source take about 12 seconds to appear in a React Native app running in an iOS simulator, whereas with the 1.9.671 such changes take about 2 seconds.

      I apologize for not having a minimal repro available. I suspect it is easily reproducible locally using a setup generated using re-natal init FutureApp (see https://github.com/drapanjanas/re-natal)

      Of note: I don't have :npm-deps set. My compiler options are:

      {:output-to     "target/ios/not-used.js"
       :main          "env.ios.main"
       :output-dir    "target/ios"
       :optimizations :none
       :checked-arrays false 
       :warnings      true}
      

      A git bisect shows that this was introduced with the change in CLJS-2212 Closed .

        Attachments

          Activity

            People

            • Assignee:
              dnolen David Nolen
              Reporter:
              mfikes Mike Fikes
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: