Interaction with *print-namespace-maps* and js objects with slash in property name

Description

Environment

None

Activity

Show:
David Nolen
July 8, 2017, 3:19 PM

I don't think Enzzo patch has any big perf implications. Looks good to me, thanks.

Enzzo Cavallo
July 8, 2017, 3:37 AM

I just signed
I write one more test for nested case.
Not sure if should be a comment on "(map? m)" saying "When it a javascript map, we should not try to lift ns"
I do not test this feature. Still reading about how to test.

Mike Fikes
July 8, 2017, 3:08 AM

Enzzo: I suspect your patch has better behavior. (There might be a perf concern with any of these patches, given the area of code being changed.) Yes, I would propose adding a test.

Also, have you signed the C/A. (Your name doesn't appear to be listed here https://clojure.org/community/contributors)

Enzzo Cavallo
July 8, 2017, 3:03 AM

I think that my PATCH will do

` #js {:foo/bar #:baz{:quux 3}} `

, not?
Should there be a test covering it?

Completed

Assignee

David Nolen

Reporter

Mike Fikes

Labels

Approval

Accepted

Patch

Code and Test