memfn docstring refers to Java and reflection

Description

Currently:

Proposed:

Environment

None

Activity

Show:
Mike Fikes
July 9, 2017, 3:12 PM

Attached re-baselined CLJS-2172-v2.patch.

David Nolen
July 9, 2017, 2:19 PM

Patch needs to be rebased to master.

Mike Fikes
July 5, 2017, 2:45 PM

Note: Even though this ticket was marked as "trivial" owing to it being simply a docstring change, the solution in CLJS-2172.patch is not trivial in that it involves exclusively using the ClojureScript-specific copy of memfn that was originally created for self-hosted. Since this is a bit more extensive of a change, added unit tests. Also, a small consequence is that doc on memfn now shows the macro symbol name as cljs.core/memfn (as it already does in self-hosted REPLs that implement doc).

I suppose, if this change is accepted, it opens the door to potentially remove the with-meta that is in the implementation, which came from the Clojure copy (if there is really no need for it in ClojureScript).

Completed

Assignee

David Nolen

Reporter

Mike Fikes

Labels

Approval

Screened

Patch

Code and Test