Undeclared var regression in fn bodies

Description

No longer produces a warning. Probably related to the changes to suppress double warnings as a result of fn invoke optimization. The fix needs to also supply an analyzer test case.

Environment

None

Activity

Show:
Mike Fikes
June 30, 2017, 3:53 AM

Since method param analysis never results in warnings being emitted, a much simpler (1-line) patch is sufficient for the problem. Attaching a v2 patch as an alternative to consider.

Mike Fikes
June 30, 2017, 3:28 AM

The root cause is fairly cut-n-dry. The solution is fairly straightforward, but perhaps a little more complex than desired. Explanation is in commit comment in the attached patch. Adds a regression test specifically for this case.

Mike Fikes
June 30, 2017, 12:58 AM

git bisect shows that this regression was introduced with the commit for CLJS-2066.

David Nolen
June 29, 2017, 11:31 PM

Actually I looked into this - not related to changes around double warnings an fn optimization. Dropping `warning-for` from analyze does not change the behavior.

Completed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

David Nolen

Reporter

David Nolen

Approval

Accepted

Patch

Code and Test