We're updating the issue view to help you get more done. 

goog-defines broken for integers

Description

Using goog-define with integer values results in cljs.closure/make-options attempting to call .setDefineToIntegerLiteral on the compiler-options object. That method does not exist; the correct method is .setDefineToNumberLiteral. Note however that calls to .setDefineToNumberLiteral will fail when the value is a long; it might make sense to always use .setDefineToDoubleLiteral when the value is a number. Integers passed to .setDefineToDoubleLiteral remain integers in the output javascript, so it seems harmless enough to do it that way.

Environment

None

Status

Assignee

Unassigned

Reporter

Tom Connors

Labels

Approval

None

Patch

None

Priority

Minor