Double warning for undeclared Var (REPL only)

Description

A regression occurred where an undeclared Var in a {{require}}d file causes two diagnostics:

Environment

None

Activity

Show:
António Monteiro
November 15, 2016, 2:29 AM

I just now realized that it will probably affect those cases as well, although the `add-dependencies` function seems to (currently) only be used in `cljs.repl`. What other approach should I try? Restrict the cases where we

at the REPL?

Thomas Heller
November 15, 2016, 2:51 AM

FWIW I don't think this is related to the REPL at all.

I have been seeing doubled warnings for a while now in shadow-build but never bothered to find you why.

Will always warn twice about "xzy" but only once for "abc", doesn't matter if a REPL is involved or not.

David Nolen
July 9, 2017, 2:34 AM

pretty sure this was resolved when Mike Fikes fixed how we process fn bodies.

David Nolen
July 9, 2017, 4:23 AM

Can confirm this is still a problem thanks to bump from António, however I do not understand the patch. It doesn't seem safe to suppress warnings here like that.

David Nolen
July 10, 2017, 9:35 PM
Completed

Assignee

David Nolen

Reporter

Mike Fikes

Labels

Approval

None

Patch

Code

Fix versions

Priority

Major