Arity-1 version of js->clj should pass keyword arguments for default options, as expected by js->clj

Description

Arity-1 version of js->clj is passing the map {:keywordize-keys false} as the default options of js->clj, when it should pass the keyword arguments :keywordize-keys false. It's working by luck, because keywordize-keys ends being nil by default, which is falsey. But it's confusing for anyone reading the code and trying to pass {:keywordize-keys true} with the expectation that it would keywordize the keys.

References: http://dev.clojure.org/jira/browse/CLJS-750 and https://groups.google.com/forum/#!topic/clojurescript/Dis6845WL5U

Environment

None

Activity

Show:
Martin Klepsch
July 21, 2016, 12:13 PM

Just stumbled upon this as well so bump

import
February 4, 2016, 11:00 PM

Yes I did, David

David Nolen
February 4, 2016, 10:05 PM

Patch looks OK, Nicolas have you submitted your CA? Thanks.

Mike Fikes
January 30, 2016, 1:59 AM
Completed

Assignee

Unassigned

Reporter

Nicolás Berger

Patch

Code