defrecord does not emit IKVReduce protocol

Description

Records are maps and in Clojure they support reduce-kv (IKVReduce protocol).
This is not true in ClojureScript:

Fails wit Error: No protocol method IKVReduce.-kv-reduce defined for type : [object Object]

Environment

None

Activity

Show:
Mike Fikes
September 27, 2018, 9:30 PM

0001-CLJS-1297-defrecord-does-not-emit-IKVReduce-protocol.patch applies cleanly, passes CI and Canary.

Erik Assum
September 27, 2018, 7:35 PM

I've created a new patch based on Samuels and kept the attribution.

Mike Fikes
September 24, 2018, 3:09 PM

Hey Samuel, can you re-baseline your attached patch? (It no longer applies on master.)

Tommi Tommi
September 24, 2018, 6:12 AM

Hi. What's the current status of this? Spec-tools fails to generate the JSON Schemas out of clojure.spec + records on cljs and there is a local fix proposed on that side: https://github.com/metosin/spec-tools/pull/130/files

Completed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

David Nolen

Reporter

Daniel Skarda

Labels

Patch

Code and Test