memoization of js-dependency-index and get-upstream-deps needs knobs

Description

knobs should be exposed for more dynamic compilation environments like Figwheel which may desire to add dependencies to the classpath on the fly.

Environment

None

Activity

Show:
Bruce Hauman
March 29, 2015, 7:22 AM

Hold off on this. Its not behaving as expected. Doesn't seem to be caching in certain situations.

David Nolen
March 29, 2015, 7:26 AM

Thanks for the update. This will definitely not land until after the pending REPL/piggieback release anyhow.

Bruce Hauman
March 29, 2015, 7:44 AM

Yeah there is an obvious bug and a subtle one. Hopefully will finish it up soonish.

Bruce Hauman
March 29, 2015, 8:43 AM

Alright, this latest patch works. There was a subtle memoizing nil value bug.

Mike Fikes
November 20, 2017, 1:04 PM

Patch no longer applies.

Assignee

Unassigned

Reporter

David Nolen

Labels

None

Approval

None

Patch

Code

Fix versions

Affects versions

Priority

Major