Add :added metadata for several functions new in Clojure 1.10

Description

I ran some code to see which public Vars in Clojure have no :added metadata, or no doc strings, and then did a 'diff' on the output for Clojure 1.7, 1.8, 1.9, 1.10.0, and 1.10.2-rc2. Below is a complete list of such Vars:

Public Vars added in Clojure 1.8.0, but no :added metadata:

clojure.core.server/repl
clojure.core.server/repl-init
clojure.core.server/repl-read
clojure.core.server/start-server
clojure.core.server/start-servers
clojure.core.server/stop-server
clojure.core.server/stop-servers

Public Vars added in Clojure 1.10.0, but no :added metadata:

clojure.datafy/datafy
clojure.datafy/nav

Public Vars added in Clojure 1.10.2, but no :added metadata:

clojure.main/err->msg
clojure.main/report-error

Public Vars added in Clojure 1.10.2, but no :added metadata and no doc string:

clojure.core/case-fallthrough-err-impl

For case-fallthrough-err-ipl, it isn't clear to me whether it was intended to be private or public. If public, is a doc string and :added metadata desired?

Environment

None

Activity

Show:
Andy Fingerhut
January 7, 2021, 2:34 AM

Attached patch clj-2601-fix-v1.patch adds :added metadata to all Vars mentioned in the issue except clojure.core/case-fallthrough-err-impl, since it isn’t clear whether that one was intended to be public.

Alex Miller
January 8, 2021, 2:28 AM

case-fallthrough-err-impl is public because the case macro expands to it so it has to be public, but it's undoc'ed as you should not call it directly. so, does not need :added.

Assignee

Unassigned

Reporter

Andy Fingerhut

Labels

None

Approval

Triaged

Patch

None

Affects versions

Priority

Minor