Minor mistakes in reify docstring

Description

reify's docstring has an unbalanced paren, unformatted code, and an unfinished sentence fragment.

Environment

None

Activity

Show:
Ambrose Bonnaire-Sergeant
January 17, 2020, 4:46 AM

Patch clj-2552-1.patch addresses these issues.

Andy Fingerhut
January 18, 2020, 3:36 PM

Is the “recur works to method heads” phrase that your patch removes information that already occurs elsewhere in the doc string? If it was accurate information, and not present elsewhere, it seems best to make it into a complete sentence, rather than delete it.

Ambrose Bonnaire-Sergeant
January 18, 2020, 6:12 PM

Yes, great point, that seems much more reasonable than deleting it. I don’t seem to have edit rights here, but if I did I’m inclined to move the “recur works to method heads” clarification to a different issue with “Minor” priority – the rest of the changes are definitely “Trivial”.

Andy Fingerhut
January 19, 2020, 1:36 AM

Are you able to add another attachment here? If not, Alex Miller should be able to restore your edit rights in the most recent instantiation of Clojure JIRA.

Ambrose Bonnaire-Sergeant
January 19, 2020, 5:21 PM

Whoops, I have edit rights already, I’m just not used to the Jira cloud interface! I’ll split the issue and clarify next week.

Assignee

Ambrose Bonnaire-Sergeant

Reporter

Ambrose Bonnaire-Sergeant

Labels

Approval

None

Patch

None

Affects versions

Priority

Trivial