Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Completed
    • Affects versions: Release 1.10
    • Fix versions: Release 1.10
    • Labels:
    • Approval:
      Ok
    • Patch:
      Code

      Description

      Java 11 has been released since we bumped the javadoc browse urls earlier in Clojure 1.10.

      In the process of adding this, I realized it's broken for Java 11 as they now require the module in the url, so should probably fix it for 1.10.

      (require '[clojure.java.javadoc :as jd])
      (jd/javadoc java.lang.String) ;; should open String javadoc, but currently broken for Java 11 (9 and 10 still work)
      

      Proposed: The attached patch hardcodes the java.base module in the Java 11 javadoc url (covers the most common Java classes, but not all). We could use class.getModule().getName() to build the generic url for all JDK classes, but that would require relying on at least Java 9 APIs to be able to make the call. For now, this does not seem worth doing. When we next bump min JDK we can revisit.

      Patch: clj-2425.patch

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              alexmiller Alex Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: