LineNumberingPushbackReader doesn't set pushback buffer size

Description

The class clojure.lang.LineNumberingPushbackReader doesn't pass size to the super call of java.io.PushbackReader, which means the pushback buffer size is 1. This easily triggers a pushback buffer overflow form me, at least when using clojure.tools.reader.edn.

Environment

None

Activity

Show:
Alex Miller
September 1, 2018, 10:10 AM

Can you include a repro example?

import
September 1, 2018, 10:55 AM

Comment made by: csm

Note, this mainly came up because I thought I could use LineNumberingPushbackReader with the tools.reader library (and I realize that may have been wrong).

As far as I can tell, this is not an issue with Clojure itself, or the built-in edn reader.

But, for a test case:

If this isn't expected to behave differently, then please close this. Thanks!

import
September 1, 2018, 11:03 AM

Comment made by: csm

Looking at EdnReader and LispReader, it doesn't look like this could ever be a problem, since those only ever push back a single character. So this bug is probably not valid, sorry for the noise.

Not Reproducible

Assignee

Unassigned

Reporter

import

Labels

None

Approval

None

Patch

None

Affects versions

Priority

Minor