clojure.spec.test/check without args tests fns from clojure.core, erroring out with #:clojure.spec{:failure :no-fn}

Description

When running (clojure.spec.test/check (in CIDER, but I doubt that's relevant other than it changes the formatting of the following snippet):

It doesn't seem appropriate to tell me that these macros have no fn to spec. Perhaps it should know about macros.

Problem: checkable-syms does not omit spec'ed macros so when they flow down to check-1, they throw errors. Since these can't be checked, they should be omitted from checkable-syms. I put the change in fn-spec-name?, which is also used (and has the same problem in) instrumentable-syms.

Approach: Skip spec'ed macros.

Patch: clj-2008.patch

Environment

N/A

Activity

Show:
Alex Miller
August 22, 2016, 4:10 PM

That's interesting as there were changes in alpha11 designed to catch and omit macros from check. So, something still amiss there.

Stuart Halloway
August 26, 2016, 1:31 PM

lvh: thanks for the report!

Not sure that we want to give up on generatively testing macros, but it certainly doesn't work atm, so this seems good until we take it on.

Completed

Assignee

Unassigned

Reporter

lvh

Labels

Approval

Ok

Patch

Code

Fix versions

Affects versions

Priority

Major
Configure