generate-proxy produces unpredictable method order in generated classes

Description

Using core/proxy to generate proxies for Java classes produces unpredictable method ordering in the generated class files.
This is a problem for repeatable builds (when doing AOT).

Specifically, I'm running Clojure inside Docker, and I'd like my application image layer to be as small as those produced by Java developers (using Meta-inf classpaths and a lib directory). Anyway, to get this working properly so that all dependencies (including those compiled as part of AOT) are on a separate layer, I need the output of compiling my applications' dependencies' proxies to be the same each time I run the build. This reduces build time, image push time, image pull time and container scheduling time.

Example code that exhibits the problem (you'll need to run it a few times to see the issue).

https://github.com/kipz/predictable-proxies

Cause: I've tracked it down to the use of an unsorted map here:

https://github.com/clojure/clojure/blob/master/src/clj/clojure/core_proxy.clj#L186

Approach: Use a sorted map, sorted by hash of the key (which is a vector of method name, seq of param types, and return type).

Patch: CLJ-1973-v5.patch

Screened by: Alex Miller

Environment

OSX, OpenJDK 8

Activity

Show:
James Carnegie
July 4, 2016, 7:06 PM

Copy paste between branches error. Tested this time.

James Carnegie
July 4, 2016, 7:14 PM

Now with more consistent formatting of 'let'

Alex Miller
July 4, 2016, 8:27 PM

While this is probably fine, it might be better to use the hash (Clojure) function rather than .hashCode (Java) function. The map itself is hashed based on the hash so that seems more appropriate.

James Carnegie
July 4, 2016, 9:15 PM

As requested, using Clojure 'hash' instead.

Thanks Alex - learned about boolean comparators too!

Alex Miller
July 4, 2016, 9:52 PM

Note that this ordering may still change across Clojure or JVM versions as there is no guarantee of hashing across those. Pre-screening for now.

Assignee

Unassigned

Reporter

James Carnegie

Labels

Approval

Screened

Patch

Code

Fix versions

Affects versions

Priority

Minor