Update parameter name to reflect docstring

Description

The docstrings for `zero?`, `pos?`, and `neg?` reference `num` but the parameter is named `x`.

Proposed: Modify code to use "num" to match docstring as "num" is more descriptive than "x".

Patch: CLJ-1859-Update-parameter-name-to-reflect-docstring.patch

Prescreened by: Alex Miller

Environment

None

Activity

Show:
Alex Miller
November 30, 2015, 7:14 PM

The inline fns should be updated too.

Matthew Boston
November 30, 2015, 7:22 PM

Thanks, Alex. I was trying to follow the existing pattern that the inline functions have shorter parameter names. New patch attached.

Erik Assum
March 4, 2017, 8:32 PM

should be closed as a duplicate of this, I assume?

Marc O'Morain
August 19, 2017, 9:26 PM

I've been going through issues that I have logged and writing some patches this evening, and I came to this issue through CLJ-2121, but I see that there is already a patch here. Can this be considered for 1.9? Seems un-controversial.

Completed

Assignee

Unassigned

Reporter

Matthew Boston

Labels

Approval

Ok

Patch

Code

Fix versions

Priority

Trivial
Configure