IExceptionInfo should print with its ex-data

Description

The new (for 1.7) data-reader printing format for exceptions does not include the ex-data when relevant:

Approach: If ExceptionInfo is caught, also print :data key with ex-data. Include :data key for each ExceptionInfo in via.

After:

Example with nested ExceptionInfo:

Patch: CLJ-1716.patch

Environment

None

Activity

Show:
gfredericks
April 27, 2015, 3:30 AM

Added two patch files, the first with tests for the existing code, the second adding the :data key and extra tests for that.

Alex Miller
April 28, 2015, 3:55 PM

Screening comments:

  • Combine the two patches into a single patch

  • Include :data for all ExceptionInfo in :via (when appropriate) (and leave it where it is)

  • when you git format-patch, throw -W on there to get more context (I think it would help in this case)

  • everything else looks good

gfredericks
April 29, 2015, 3:44 PM

Cool – I'm assuming "single patch" implies "single commit" since I couldn't find a way to dump two commits into one patch file.

Alex Miller
April 29, 2015, 4:08 PM

yeah, single commit is what I meant. you can just commit multiple times and format-patch to get a single patch with multiple commits, but would prefer single.

gfredericks
April 30, 2015, 3:14 PM

Attached CLJ-1716.patch, which has just one commit, and now attaches data both to everything appropriate in :via and at the top level (so the data for the root cause is duplicated).

Added one more test case while I was at it.

Completed

Assignee

Unassigned

Reporter

gfredericks

Labels

Approval

Ok

Patch

Code and Test

Fix versions

Affects versions

Priority

Major