data_readers hard coded to .clj extension, should be extended to .cljc

Description

Currently using data_readers in ClojureScript is difficult because the extensions are not available to both compile time and runtime as they are in Clojure. This is fairly straightforward to remedy now given the presence of conditional reading - simply supply data_readers.cljc.

Approach: Find and read both data_readers.clj and data_readers.cljc. For cljc, allow reader conditionals.

Alternative: Another option would be to just allow reader conditionals on the existing data_readers.clj file. That's a simpler patch but possibly confusing given that conditionals are only available in .cljc files right now.

Patch: clj-1699.patch - tested with a variety of manual tests

Environment

None

Activity

Show:
David Nolen
April 10, 2015, 10:23 PM

This could be solved trivially by concatenated data_readers.cljc resources to the return value of clojure.core/data-reader-urls.

Completed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Unassigned

Reporter

David Nolen

Labels

Approval

Ok

Patch

Code

Priority

Major

Affects versions

Fix versions